Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🔥 Allow automation to run from manual triggers. #1143

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

whizzzkid
Copy link
Contributor

Removing check `github.event_name == 'push'

@whizzzkid whizzzkid requested review from lidel and a team as code owners February 2, 2023 08:17
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding github.event_name == 'workflow_dispatch' feels safer

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
SgtPooki and others added 2 commits February 2, 2023 09:27
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with lidel's suggestions. We shouldn't remove event type entirely.

@lidel
Copy link
Member

lidel commented Feb 3, 2023

@whizzzkid feel free to merge when you have time to eyeball if it works as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants